chore: refactor scroll to bottom logic#11872
Conversation
|
Does it still scroll if I have the chat open in a call on my second screen and work in my IDE on the other screen? |
|
Filling the truth table for 5 arguments we're using: 🛑 - no scroll at all Remark:
Remark: !isVisible && hasFocus is impossible case, omitted from table
if Looking at the cycle, isInCall and hasFocus can be omitted, and 'force' treated separately before other logic: if (force) {
🔽
} else if (!sticky) {
🛑
} else if (!visible) {
❎
} else {
🔽
} |
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
…crolling in case of reaction added. Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
75e711b to
9beca0c
Compare
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
9beca0c to
7cbc5d3
Compare
☑️ Resolves
🚧 TODO follow-up :
clientHeight(it scrolls when joining a conversation) !